Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split main into functions for easier testing #885

Closed

Conversation

jfrost-mo
Copy link
Member

@jfrost-mo jfrost-mo commented Nov 5, 2024

This will make it easier to test. I'll make a follow up PR adding those tests before merging this one.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@jfrost-mo jfrost-mo self-assigned this Nov 5, 2024
@jfrost-mo jfrost-mo added the cleanup Non-functional improvement label Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Coverage

This prevents the sudden wall of tracebacks when you have just typoed a
file path. The full traceback is still output for DEBUG logging (-vv).

Fixes #581
@jfrost-mo jfrost-mo force-pushed the 581_nicer_exception_messages branch from 2c4f83d to 710f737 Compare November 8, 2024 16:25
@jfrost-mo jfrost-mo force-pushed the split_main_into_functions branch from 32e41ee to 47ada4e Compare November 8, 2024 16:26
@jfrost-mo jfrost-mo changed the title Split main into functions Split main into functions for easier testing Nov 8, 2024
@jfrost-mo jfrost-mo force-pushed the 581_nicer_exception_messages branch from 710f737 to 35a60bd Compare December 5, 2024 15:59
@jfrost-mo jfrost-mo closed this Dec 5, 2024
@jfrost-mo jfrost-mo deleted the split_main_into_functions branch December 5, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Non-functional improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant